This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Rules - Add Laravel 11 best practices #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is my first PR, please be kind :) |
alexsoyes
reviewed
Jun 14, 2025
Contributor
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Eh voilà, chaud de splitter tout ça ? On peut le faire ensemble si tu veux !
| @@ -0,0 +1,147 @@ | |||
| --- | |||
| description: | |||
| description: Apply Laravel 11 best practices for project structure, configuration, business logic, controllers, templates, forms, internationalization, security, web assets, and tests in all PHP source files. Ensures maintainability, security, and consistency across Laravel applications by following official recommendations. | ||
| globs: src/**/*.php | ||
| alwaysApply: false | ||
| --- |
| - Maximum 5 parameters per method | ||
| - Maximum 300 lines per class | ||
| - Maximum 10 classes per directory | ||
| - Use PSR-12 coding standards |
Contributor
There was a problem hiding this comment.
A partir d'ici c'est good
| - Keep listeners focused on single responsibility | ||
|
|
||
| Coding Standards: | ||
| - Use strict types everywhere: `declare(strict_types=1);` |
Contributor
There was a problem hiding this comment.
C'est dans des règles de coding standards globales, pas besoin de les repréciser ici :)
| alwaysApply: false | ||
| --- | ||
|
|
||
| Project Structure: |
Contributor
There was a problem hiding this comment.
Pas mal du tout, tu peux demander à l'agent de te regrouper les règles et de te spliter ça en plusieurs petits fichiers, ça te permettra de target uniquement les contrôleurs quand tu as besoin, l'ORM d'un autre côté etc
| - Use interfaces for better testability | ||
| - Bind interfaces to implementations in service providers | ||
|
|
||
| Models & Eloquent: |
Contributor
There was a problem hiding this comment.
ça va avec l'ORM plus bas, pense à merge :)
Author
|
Merci pour tes retours ! À mon retour de vacs je m'en occupe! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.