Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 5, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

P1 Badge Legacy UI not started after webview failure in reconnect path

When the app starts in fallback mode and later _open_webview_after_fallback() schedules a webview launch, run() exits the Tk loop, sets pending_webview and calls start_webview_runtime() (lines 882‑884). If webview.start() raises an exception, the new code builds the legacy interface and sets force_legacy_ui inside start_webview_runtime() (lines 892‑914) but then returns False. Because run() does not re‑enter self.root.mainloop() after this call, the newly created Tk window never runs and the process simply terminates. Users who lose the webview during the reconnect flow will be left without any UI. Consider re‑starting the Tk main loop (or looping) when start_webview_runtime() fails so that the legacy UI actually appears.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in #91 (comment)

Original prompt

This section details on the original issue you should resolve

<issue_title>P1 Badge Legacy UI not started after webview failure in reconnect path</issue_title>
<issue_description>P1 Badge Legacy UI not started after webview failure in reconnect path

When the app starts in fallback mode and later _open_webview_after_fallback() schedules a webview launch, run() exits the Tk loop, sets pending_webview and calls start_webview_runtime() (lines 882‑884). If webview.start() raises an exception, the new code builds the legacy interface and sets force_legacy_ui inside start_webview_runtime() (lines 892‑914) but then returns False. Because run() does not re‑enter self.root.mainloop() after this call, the newly created Tk window never runs and the process simply terminates. Users who lose the webview during the reconnect flow will be left without any UI. Consider re‑starting the Tk main loop (or looping) when start_webview_runtime() fails so that the legacy UI actually appears.

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in #91 (comment)
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #92

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@alebmorais alebmorais marked this pull request as ready for review October 5, 2025 19:19
@alebmorais alebmorais merged commit 4ea3525 into main Oct 5, 2025
2 of 3 checks passed
@alebmorais alebmorais deleted the copilot/fix-af2e1b74-329e-41ef-aba5-881b6b17a20a branch October 5, 2025 19:19
Copilot AI restored the copilot/fix-af2e1b74-329e-41ef-aba5-881b6b17a20a branch October 5, 2025 19:19
Copilot AI requested a review from alebmorais October 5, 2025 19:19
@alebmorais alebmorais deleted the copilot/fix-af2e1b74-329e-41ef-aba5-881b6b17a20a branch October 7, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Legacy UI not started after webview failure in reconnect path**

2 participants