Modernize test projects #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplify conditional framework targeting by _adding_ net462 to the $(TargetFrameworks) on Windows only instead of _repeating_ the supported target frameworks.
Targeting .NET Framework on Linux and macOS works fine [since the .NET 5 SDK][1]. Note: this is required for the CacheCow.Server.WebApi project to build on Linux and macOS. [1]: dotnet/sdk#4009 (comment)
0xced
force-pushed
the
modernize-tests
branch
from
9759beb to
2e416ad
Compare
…ions Also remove the transitive dependencies (e.g. Newtonsoft.Json, Microsoft.AspNet.WebApi.Client) from test projects.
0xced
force-pushed
the
modernize-tests
branch
from
2e416ad to
d3186ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newtonsoft.JsonandMicrosoft.AspNet.WebApi.Client) from test projects.Targeting .NET Framework on Linux and macOS works fine since the .NET 5 SDK.
Note: dropping conditional targeting is required for the
CacheCow.Server.WebApiproject to build on Linux and macOS.