Postgresql support #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, and thank you for this project!
With his changes it's possible to run opencms_docker with postgresql db. All of the new options fallback to the previous value, so existing users shouldn't notice anything, the old compose file still works with same result.
Added docker compose example:
docker-compose-pgsql.yml, updated README as well.Other small fixes:
image/resources/root/wait-for.sh: made theHOST:PORTparameters optional, defaults to the$DB_HOST:$DB_PORTenvvars. This way the user have to set only the$DB_HOSTand$DB_PORTas envvars, no duplication needed on thecommandline.image/Dockerfile:VOLUMEinstruction for better mounting.docker-compose.yml: A lot of old options, they are not needed anymore, the container runs and builds perfectly without them.image/resources/root/opencms-run.sh: Time zone can be applied by simply setting theTZenvvar, so these timezone related code is not necessary.