Resizing view after setMaxLength called #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing two issues with setMaxLength if you call it after the view has been initialized. When you call setMaxLength it now calls onSizeChanged to update all the values. In onSizeChanged the width and height is recorded for future use if setMaxLength is called. 1 - If number is larger than the initialized number, it will crash with an out of bounds exception. E.g 4 -> 5 2 - If the number is smaller than initialized number, the view will retain the width of the initial number, and the smaller entry dashes will be displayed starting from the left and then stopping mid way through the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two issues with setMaxLength if you call it after the view has been initialized. (e.g. after a button press)
When you call setMaxLength it now calls onSizeChanged to update all the values. In onSizeChanged the width and height is recorded for future use if setMaxLength is called.
1 - If number is larger than the initialized number, it would crash with an out of bounds exception. E.g 4 -> 5
2 - If the number is smaller than initialized number, the view would retain the width of the initial number, and the smaller entry dashes would be displayed starting from the left and then stopping mid way through the screen.