Enhanced watchmode #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow an external program to be specified to watch particular games to make use of NH4's wachmode. Add game config options watch_path, watch_args and watchcommands to support this. Also add %w/%W for format tokens the watched player, and %l/%L for the logged-in user because %n/%N fall back to the watched player if nobody is logged in, which is not always what we want. Watch menu now displays N/A for the terminal size of games which use this, because NH4 watch mode does not care about player's terminal dimensions. Other external watching tools may need this in the future, but for now there is nothing that requires this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an external program to be specified to watch particular games
to make use of NH4's wachmode. Add game config options watch_path,
watch_args and watchcommands to support this. Also add %w/%W for
format tokens the watched player, and %l/%L for the logged-in user
because %n/%N fall back to the watched player if nobody is logged
in, which is not always what we want. Watch menu now displays N/A
for the terminal size of games which use this, because NH4 watch
mode does not care about player's terminal dimensions. Other external
watching tools may need this in the future, but for now there is
nothing that requires this.