feat: add pino logger and some debug logs #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsilspatel
requested changes
Aug 6, 2021
Contributor
harsilspatel
left a comment
harsilspatel
left a comment
There was a problem hiding this comment.
Almost all logs follow a pattern, logger.debug(<object>, "<module>, <fn>, <object>");
Find if there's an easy way to get module and fn then abstract that logic into a function, say getLogId then use it like so
logger.debug(<object>, `${getLogId()} <object>`);```
harsilspatel
requested changes
Aug 7, 2021
server/controller.ts
Outdated
|
|
||
| import * as service from "./service"; | ||
| import { logger } from "./index"; | ||
| import path from "path"; |
Contributor
There was a problem hiding this comment.
Well tried but this implementation introduces even more repetitive code. The trick is to either parse it from stack trace (some examples on SO) or use something like https://github.com/felixge/node-stack-trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.