Add support for other fields #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the work in https://github.com/rainlake/node-lightify
Owner
|
Thanks for your pull request. Unfortunately, I've been busy recently, but see some light at the end of the tunnel in March. Let me review and merge then. |
Owner
|
Hi @durera , since this package is now unmaintained, you may consider submitting a pull request towards https://github.com/tfriedel/python-lightify @tfriedel will pick this up. Regards, Andreas |
Repository owner
deleted a comment from
Soumya6Tiwari
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the properties supported by this python library based on the work in rainlake/node-lightify for my ibm-watson-iot/gateway-lightify project. Figured you may be interested in this (or a version of it) to add support for the additional properties.
Also,
namehas been made updateable, rather than fixed at initialization.Mainly involved adding new getter methods and rewriting the binary data unpacking.