fix: Correct detection box rendering with letterboxed/pillarboxed video #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getVideoRect() function returns CGRect (non-optional), but the code was using 'if let' optional binding. Changed to direct assignment since the return value is not optional. Fixes build error: "initializer for conditional binding must have Optional type, not 'CGRect'" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Detection boxes were appearing as vertical lines because coordinates were being transformed using the container geometry size instead of the actual video dimensions. Root cause: - Detection coordinates are normalized to original video dimensions - But coordinate transformation used container geometry size - This caused incorrect scaling when video had letterboxing/pillarboxing Solution: - Pass videoSize to prepareObjectForSwiftUI for correct transformation - Scale transformed coordinates to fit the container geometry - Maintain backward compatibility with optional parameter Fixes: andrewginns#3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ebowwa
force-pushed
the
fix/detection-box-rendering
branch
from
4c2de76 to
a792910
Compare
…dering # Conflicts: # CoreMLPlayer/Views/SubViews/DetectionView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes detection boxes appearing as vertical lines when video is letterboxed or pillarboxed.
Problem
Detection coordinates are normalized to original video dimensions, but were being transformed using the container geometry size. This caused incorrect rendering when the video aspect ratio differed from the container.
Solution
Modified
prepareObjectForSwiftUIto accept an optionalvideoSizeparameter:Changes
Base.swift: UpdatedprepareObjectForSwiftUIwith videoSize parameterDetectionView.swift: Pass videoSize through to coordinate transformationTest Plan
Related
Fixes: #3
Documentation: https://github.com/ebowwa/CoreMLPlayer/blob/fix/detection-box-rendering/docs/bug-detection-box-rendering.md
🤖 Generated with Claude Code