-
Notifications
You must be signed in to change notification settings - Fork 59
Update dependencies and add visibility toggling and layout-based scale resizing to the glTF #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update the compileSDK & targetSDK to the latest - Include a compile-only dependency on the XR extensions to allow for Proguard minification - Add the ability to toggle the visibility of the bugdroid glTF - Scale the size of the bugdroid glTF when the associated panel is resized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fuentespatrick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the project's dependencies and enhancing the glTF model's interactive capabilities. Key changes include upgrading the Android SDK versions and various libraries to their latest, introducing the ability to toggle the visibility of the Bugdroid glTF model, and implementing dynamic resizing of the glTF model based on its containing UI panel. These updates aim to improve application stability, leverage newer platform features, and provide a more responsive user experience, while also fixing issue #12.
Highlights
- Dependency and SDK Version Updates: The project's
compileSdkandtargetSdkhave been upgraded to version 36, ensuring compatibility with the latest Android features and behaviors. Additionally, various other dependencies, including Android Gradle Plugin, AndroidX XR libraries, and Kotlin, have been updated to their latest stable versions. - Bugdroid glTF Visibility Toggling: A new feature has been implemented that allows users to toggle the visibility of the Bugdroid glTF model within the application. This is controlled via a button that dynamically changes its text based on the model's current visibility state.
- Layout-Based glTF Model Resizing: The Bugdroid glTF model now dynamically scales its size based on the dimensions of its associated UI panel. This ensures the model maintains an appropriate visual presence regardless of layout changes, leveraging new
SceneCoreEntityandSceneCoreEntitySizeAdaptercomponents. - XR Environment and glTF Rendering Refactor: Significant refactoring has occurred in how XR environment settings are managed and how glTF models are loaded and rendered. This includes updating API calls for spatial environment modes and adopting a new caching mechanism for glTF models to improve performance and resource management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates various dependencies and introduces new functionality for toggling the visibility and dynamically scaling the bugdroid glTF model. The implementation of a cache for the glTF model is a great addition for performance. However, I've identified a critical type mismatch and a high-severity thread-safety issue in the new BugdroidModel.kt file that should be addressed to ensure correctness and robustness.
Fixes #12