feat: add global non-interactive mode support #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --no-input flag and no_input config setting to disable all interactive prompts. When enabled, commands fail immediately with descriptive errors instead of prompting for missing required fields, making the tool suitable for programmatic usage, scripts, and CI/CD pipelines. The feature can be enabled via: - CLI flag: --no-input - Config file: no_input: true in ~/.jira/.config.yml - Environment variable: JIRA_NO_INPUT=true All commands that require user input now support non-interactive mode and exit with status code 1 when required fields are missing.
- Add TestShallOverwrite table-driven test with both true/false cases - Replace trivial TestErrNoInputRequired with TestConfigureInstallationTypeNoInput that verifies actual feature behavior (error on missing required field) - Add TestNoInputConfigurationMethods to verify all three config methods work: environment variable (JIRA_NO_INPUT), config file (viper.Set), and precedence Addresses code review recommendations for more meaningful test coverage.
- Add error checking for os.Setenv/os.Unsetenv calls in configuration tests - Remove unused originalBody parameter from hasNoChanges function - Improve test coverage for no-input configuration methods
ccoVeille
reviewed
Oct 28, 2025
internal/cmdutil/utils_test.go
Outdated
Comment on lines
391
to
394
| os.Setenv("JIRA_NO_INPUT", "true") | ||
| }, | ||
| cleanup: func() { | ||
| os.Unsetenv("JIRA_NO_INPUT") |
There was a problem hiding this comment.
You can directly use t.SetEnv
There is no need for cleaning up
It would also fix the linting issues you have right now
internal/cmdutil/utils_test.go
Outdated
| viper.Reset() | ||
| viper.AutomaticEnv() | ||
| viper.SetEnvPrefix("jira") | ||
| os.Unsetenv("JIRA_NO_INPUT") |
There was a problem hiding this comment.
This one could be removed
Suggested change
| os.Unsetenv("JIRA_NO_INPUT") |
I feel like you added it for avoiding possible issues with parallel testing
There was a problem hiding this comment.
You don't have to remove the parallel testing. t.SetEnv is safe while os.SetEmv wasn't
internal/cmd/issue/edit/edit.go
Outdated
| } | ||
|
|
||
| // hasNoChanges checks if any editable fields were provided in the params. | ||
| func hasNoChanges(params *editParams) bool { |
There was a problem hiding this comment.
Shouldn't it be this?
Suggested change
| func hasNoChanges(params *editParams) bool { | |
| func hasNoChanges(params *editParams) bool { |
And so, it could become a method
Suggested change
| func hasNoChanges(params *editParams) bool { | |
| func (params *editParams) hasNoChanges() bool { |
- Use t.Setenv() for cleaner test setup - Convert hasNoChanges to method receiver - Remove t.Parallel() from environment variable tests - Remove unnecessary t.Cleanup calls
Author
|
@ccoVeille Thank you for the careful review. Go is not my preferred language and it showed here! Appreciate the help. Pushed da24dda with your suggestions. |
- Remove t.Parallel() from tests using viper.Reset() (not thread-safe) - Tests now run sequentially to avoid data races on viper singleton
Author
|
The issues in the DeepSource: Go checks don't appear to have been introduced by my changes. |
ichoosetoaccept
pushed a commit
to ichoosetoaccept/jira-cli
that referenced
this pull request
Nov 28, 2025
Cherry-picked from idleyoungman/feat/global-no-input-mode Original author: Dan Young
ichoosetoaccept
pushed a commit
to ichoosetoaccept/jira-cli
that referenced
this pull request
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--no-inputflag andno_inputconfig setting to disable all interactiveprompts. When enabled, commands fail immediately with descriptive errors
instead of prompting for missing required fields, making the tool suitable
for programmatic usage, scripts, and CI/CD pipelines.
The feature can be enabled via:
--no-inputno_input: truein~/.jira/.config.ymlJIRA_NO_INPUT=trueAll commands that require user input now support non-interactive mode and
exit with status code 1 when required fields are missing.