Locking hotfix #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praboud-ant
commented
Nov 24, 2025
| # Make sure cluster mode is enabled on this node | ||
| try: | ||
| cluster_slots = str_if_bytes(r.execute_command("CLUSTER SLOTS")) | ||
| r.connection_pool.disconnect() |
Collaborator
Author
There was a problem hiding this comment.
Removing this disconnect() actually turns out to be the most important part of this change, although I didn't know it at the time. I'm highly suspicious that disconnecting these connections can cause a connection storm when one node gets overwhelmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks redis/redis-py#3803 onto our hotfix branch, because I'm having trouble getting redis-py core to review this change. See the original PR for description / motivation.