Skip to content

Conversation

@tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Dec 29, 2025

Adding envoy_data_plane dependency. This helps us add Envoy client in ApacheBeam to support ratelimiter(#37135)

Notes

  1. We need to add v3 rls proto to beam for supporting envoy client.
  2. It is difficult to add .proto file directly and manage its versions, so using this library to provide the protobufs that we can directly use
  3. This library brings grpcio, protobuf dependencies(which is expected). Which conflicts with grpcio pinning([Python] Significant test flakiness after upgrading to grpcio 1.66.0  grpc/grpc#37710 (comment)) for python <313. It also conflicts with ml tests with tensorflow which works on lower protobuf(<6) versions. So i am using older versions of envoy-data-plane for py <313. we can upgrade once grpc issue is resolved and ml dependencies start supporting latest versions(not sure if this is right approach). My usecase for now works as i only use proto.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new core dependency, envoy-data-plane, specifically targeting Python 3.13+ environments. This addition is crucial for integrating functionalities that leverage Envoy's data plane capabilities within the Python SDK. Concurrently, the necessary license and notice information for grpcio-tools has been updated to maintain compliance.

Highlights

  • New Dependency Added: The envoy-data-plane package has been added as a new installation requirement for Python versions 3.13 and above, with version constraints >=1.0.3,<2.
  • License Information Update: License and notice URLs for grpcio-tools have been added to the dep_urls_py.yaml file, ensuring proper attribution for this dependency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/update_python_dependencies.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

tarun-google and others added 2 commits December 29, 2025 16:59
@tarun-google tarun-google marked this pull request as ready for review December 29, 2025 17:14
@github-actions github-actions bot removed the build label Dec 29, 2025
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

tarun-google and others added 3 commits December 29, 2025 19:08
@tarun-google
Copy link
Contributor Author

Run Python_ML PreCommit 3.13

@tarun-google
Copy link
Contributor Author

Run Python_Runners PreCommit 3.12

@tarun-google
Copy link
Contributor Author

R: @damccorm , @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

install_requires=[
'cryptography>=39.0.0,<48.0.0',
'envoy-data-plane>=1.0.3,<2; python_version >= "3.13"',
'envoy-data-plane<0.3.0; python_version < "3.13"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment to reconcile these versions once we upgrade to a newer version of grpcio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants