[COLLECTIONS-881] MultiMapUtils.getXXX ensure safe copy #669
Conversation
| } | ||
|
|
||
| @Test | ||
| void testGetValuesAsBagIsSafeCopy() { |
There was a problem hiding this comment.
This test doesn't prove anything about the changes in main because it passes without changes to main.
| } | ||
|
|
||
| @Test | ||
| void testGetValuesAsListIsSafeCopy() { |
There was a problem hiding this comment.
OTOH, this test does prove the changes in main matter because it fails without changes to main.
| } | ||
|
|
||
| @Test | ||
| void testGetValuesAsSetIsSafeCopy() { |
There was a problem hiding this comment.
This test doesn't prove anything about the changes in main because it passes without changes to main.
clapppp
force-pushed
the
COLLECTIONS-881-MultiMapUtils.getXXX
branch
from
2d5dff4 to
5a11203
Compare
|
Thank you for the feedback! I reviewed my test cases and found the issues. However, I couldn't find any |
|
Hi @clapppp
|
clapppp
force-pushed
the
COLLECTIONS-881-MultiMapUtils.getXXX
branch
from
5a11203 to
75200cf
Compare
| @Test | ||
| void testGetValuesAsSet() { | ||
| assertNull(MultiMapUtils.getValuesAsList(null, "key1")); | ||
| assertNull(MultiMapUtils.getValuesAsSet(null, "key1")); |
| } | ||
|
|
||
| @Test | ||
| void testGetValuesAsBagIsSafeCopy() { |
There was a problem hiding this comment.
I added the test case using EasyMock, consistent with the project's existing dependencies.
|
I made the changes as you suggested. |
2 participants
This PR modifies getXXX method to return new Collection.
Updated getValuesAsSet, getValuesAsList, and getValuesAsBag to always return a new copy.
Added unit tests to verify that returned collections are independent of the backing map.
Updated Javadocs to reflect that a new collection is returned.