chore: check generated snapshots #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to #10
I found it quite tricky, and we may need some collaboration from other languages as well to make the snapshot generation more sane.
This is only for tracking the general test structure, how the snapshot generator should work, and the integration tests use generated snapshots.
So far, we can check in the snapshot files as is; just ensure they are excluded from the final crate release. And since they are in binary format, either generating it on the fly or downloading it from somewhere (e.g., GitHub raw assets, nightlies.apache.org) isn't that technically different.
The main purpose here, from what I can see, is to improve interoperability regression tests between different language implementations by exposing the functionality to create snapshots. Then we may have a dedicated repo to hold these snapshots, tag them with the generated date, and download them before running the test.