[FLINK-36296][Connectors/DynamoDB] Add support for incremental shard discovery for DynamoDB Streams Source #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejanshrana
approved these changes
Sep 11, 2025
tejanshrana
left a comment
tejanshrana
left a comment
There was a problem hiding this comment.
Thank you for contributing this feature
tejanshrana
reviewed
Sep 11, 2025
.../org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java
Outdated
Show resolved
Hide resolved
davidradl
reviewed
Dec 2, 2025
davidradl
reviewed
Dec 2, 2025
| DynamoDbStreamsSourceEnumeratorState checkpoint) | ||
| throws Exception { | ||
| int maxApiCallAttempts = sourceConfig.get(DYNAMODB_STREAMS_RETRY_COUNT); | ||
| Duration minDescribeStreamDelay = |
There was a problem hiding this comment.
in the name of the variable minDescribeStreamDelay, why does it include the word Describe
ferenc-csaky
requested changes
Dec 6, 2025
ferenc-csaky
left a comment
ferenc-csaky
left a comment
There was a problem hiding this comment.
Thanks for this change. Pls. see my comments.
.../org/apache/flink/connector/dynamodb/source/enumerator/event/SplitsFinishedEventContext.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxyTest.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/connector/dynamodb/source/enumerator/event/SplitsFinishedEventContext.java
Show resolved
Hide resolved
...main/java/org/apache/flink/connector/dynamodb/source/reader/DynamoDbStreamsSourceReader.java
Show resolved
Hide resolved
...rg/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReader.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/flink/connector/dynamodb/source/util/DynamoDbStreamsProxyProvider.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @ferenc-csaky @davidradl i have addressed your comments in the PR! |
ferenc-csaky
requested changes
Dec 10, 2025
...in/java/org/apache/flink/connector/dynamodb/source/split/DynamoDbStreamsShardSplitState.java
Outdated
Show resolved
Hide resolved
…discovery for DynamoDB Streams Source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
DynamoDB has launched a new shard filter API in DescribeStream to discover child shards of a parent shard in AWS SDK 2.32.0. This PR adds support for this new feature.
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))