Skip to content

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Dec 24, 2025

Summary

NIFI-15387
Re-enabled nine out of eleven tests in TestFetchFile, fourteen out of eighteen in TestListFile and eight of nine tests in TestPutFile to run on Windows. Also for the disabled test testNonReadableFile in StandardFileResourceServiceTest specified a disabled reason as it is the same reason for disabling testPutFile in TestPutFile. In addition, I also followed some of the Intellij suggestions for cleaning up the code.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1 dan-s1 changed the title NIFI-15387 Re-enabled nine out of eleven tests in TestFetchFile to run on Windows. NIFI-15387 Re-enabled nine out of eleven tests in TestFetchFile and eight of nine tests in TestPutFile to run on Windows. Dec 24, 2025
@dan-s1 dan-s1 changed the title NIFI-15387 Re-enabled nine out of eleven tests in TestFetchFile and eight of nine tests in TestPutFile to run on Windows. NIFI-15387 Re-enabled TestFetchFile, TestListFile and TestPutFile to run on Windows. Dec 24, 2025
@dan-s1 dan-s1 changed the title NIFI-15387 Re-enabled TestFetchFile, TestListFile and TestPutFile to run on Windows. NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. Dec 25, 2025
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @dan-s1. It looks like at least one test is failing on Windows with the current changes, it seems like the message pattern needs to be simplified to avoid the tight coupling to the message.

TestListFile.testFilterPathPattern:653->assertVerificationOutcome:945 Expected verification result to match pattern [Successfully listed .* Found 4 objects.  Of those, 1 matches the filter.].  Actual explanation was: Successfully listed contents of Local Directory [D:\a\nifi\nifi\nifi-extension-bundles\nifi-standard-bundle\nifi-standard-processors\target\test\data\in].  Found 4 objects.  Of those, 0 match the filter. ==> expected: <true> but was: <false>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants