Skip to content

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15305 Corrects String to LocalDateTime conversion for floating point numbers represented as strings.

The current implementation checks long numbers for values larger than the year 10,000, but does not implement a similar check for floating point numbers represented as strings.

The corrected approach checks the integral part of a floating point number for values larger than the year 10,000 in seconds, and then handles the number as epoch milliseconds. The parsing strategy also handles the fractional part as either the number of microseconds or the number of milliseconds.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added check for integral numbers greater than expected number of seconds for year 10,000 and handled as milliseconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant