RATIS-2244. Reduce the number of log messages during bootstrap #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted very frequently and it rolls off 30 log files (of 200MB each) in 15 mins. Since logs are rolled off too quick, troubleshooting cause of bootstrap is becoming difficult.
szetszwo
reviewed
Jan 29, 2025
Contributor
There was a problem hiding this comment.
@venkatsambath , thanks a lot for working on this!
Let's use BatchLogger. It will reduce the number of log messages greatly. See https://issues.apache.org/jira/secure/attachment/13074367/1216_review.patch
szetszwo
changed the title
Contributor
Author
|
Thank you @szetszwo for your patch. it looks great. please proceed further with the fix. |
Contributor
Author
|
Sorry. I closed this PR by mistake. I've created #1217 with the changes proposed in review patch. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the Ozone OM falls back and bootstraps, the logs are printed very frequently and it rolls off 30 log files (of 200MB each) in 15 mins. Since logs are rolled off too quick, troubleshooting cause of bootstrap is becoming difficult.
What changes were proposed in this pull request?
Changed logging level on installsnapshot notification from WARN to DEBUG. This is to avoid frequent logging on bootstapping OM.
Changed logging level on inconsistency message to DEBUG too.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2244
How was this patch tested?
Logging change. Didnt create unit test for this change.