Skip to content

Conversation

@aglinxinyuan
Copy link
Contributor

@aglinxinyuan aglinxinyuan commented Dec 14, 2025

What changes were proposed in this PR?

Remove the Apache header and add back the MIT header for 3rd-party source files.

Any related issues, documentation, discussions?

Fixes #4133

Was this PR authored or co-authored using generative AI tooling?

No.

Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
@aglinxinyuan aglinxinyuan changed the title fix: License header for Pyright language server fix: license header for Pyright language server Dec 14, 2025
@aglinxinyuan aglinxinyuan self-assigned this Dec 14, 2025
Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>
@Yicong-Huang
Copy link
Contributor

Yicong-Huang commented Dec 15, 2025

@aglinxinyuan can you open a new issue for this change? We want to include the issue in #4080.

@aglinxinyuan
Copy link
Contributor Author

@aglinxinyuan can you open a new issue for this change? We want to include the issue in #4080.

The issue is described in PR #3415. Can we use PR #3415 as a reference?

@aglinxinyuan aglinxinyuan marked this pull request as ready for review December 15, 2025 05:34
@Yicong-Huang
Copy link
Contributor

@aglinxinyuan can you open a new issue for this change? We want to include the issue in #4080.

The issue is described in PR #3415. Can we use PR #3415 as a reference?

No it is not the the same as #3415. In #3415 you are adding license header. Here you are changing it. They are two tasks.

@aglinxinyuan
Copy link
Contributor Author

aglinxinyuan commented Dec 15, 2025

@aglinxinyuan can you open a new issue for this change? We want to include the issue in #4080.

The issue is described in PR #3415. Can we use PR #3415 as a reference?

No it is not the the same as #3415. In #3415 you are adding license header. Here you are changing it. They are two tasks.

PJ describes the issue in the reply to PR #3415. Since it is confusing, I will create an issue. Issue #4133

@chenlica
Copy link
Contributor

@aglinxinyuan : @bobbai00 is traveling and may have limited availability. Besides him, can you recommend another committer to review it?

@aglinxinyuan
Copy link
Contributor Author

@aglinxinyuan : @bobbai00 is traveling and may have limited availability. Besides him, can you recommend another committer to review it?

@Yicong-Huang can review it.

bobbai00 pushed a commit to bobbai00/texera that referenced this pull request Dec 17, 2025
Remove pyright-language-service license header changes as they are
already addressed in PR apache#4132. This commit now focuses only on:

- mbknor-jackson-jsonschema (MIT license attribution)
- Angular array.type.ts (MIT license attribution)
- sbt-license-report plugin for dependency tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix license header for Pyright language server

3 participants