Skip to content

TEZ-4643: Enforce speculation configuration to prevent execution on normal tasks. #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qijiale76 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

TEZ-4643: Enforce speculation configuration to prevent execution on normal tasks. #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tez-dag/src/main/java/org/apache/tez/dag/app/dag/speculation/legacy/LegacySpeculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,9 @@ private long speculationValue(Task task, long now, boolean shouldUseTimeout) {
return TOO_NEW;
}

long taskRuntime = now - taskAttemptStartTime;
if (shouldUseTimeout) {
if ((now - taskAttemptStartTime) > taskTimeout) {
if (taskRuntime > taskTimeout) {
// If the task has timed out, then we want to schedule a speculation
// immediately. However we cannot return immediately since we may
// already have a speculation running.
Expand All @@ -380,6 +381,10 @@ private long speculationValue(Task task, long now, boolean shouldUseTimeout) {
return ON_SCHEDULE;
}
} else {
if (taskRuntime < acceptableRuntime) {
return ON_SCHEDULE;
}

long estimatedRunTime = estimator
.estimatedRuntime(runningTaskAttemptID);

Expand Down