Add keycard support #662
Draft
Add keycard support #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Add keycard support as alternative to MNEMONIC based signer
This PR adds support for keycard by implementing keycard-hardhat-provider plugin.
accountsobject is changed to optional to allowkeycardAccountto override the main signer.KEYCARD_ACCOUNTis a wallet address, once it is placed in .env file hardhat config will expect a keycard wallet with specified account. If there is no wallet addresskeycardAccountwill not be configured.Additional changes:
A transaction confirmation is added to
deployApi3ReaderProxyV1to avoid transaction overlap while deploying contracts.