-
Notifications
You must be signed in to change notification settings - Fork 202
feat: add screenshotsGenerated metrics across console #2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b7e99ba
80fb7f6
930d0fb
1af8a32
524336d
53b9707
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should instead start using the generated SDK, it should already have these |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, generated SDK should have these. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -347,6 +347,12 @@ | |
| getResource(resources, 'imageTransformations'), | ||
| currentPlan?.imageTransformations | ||
| ), | ||
| createResourceRow( | ||
| 'screenshots-generated', | ||
| 'Screenshots generated', | ||
|
Comment on lines
+351
to
+352
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all the ids and text that are passed to createResourceRow(
'screenshots-generated', // simply replace `-` with a ` ` and making the first char uppercased
getResource(resources, 'screenshotsGenerated'),
currentPlan?.screenshotsGenerated
), |
||
| getResource(resources, 'screenshotsGenerated'), | ||
| currentPlan?.screenshotsGenerated | ||
| ), | ||
| createResourceRow( | ||
| 'gb-hours', | ||
| 'GB-hours', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats this for?