Refactor to use scylladb/termtables #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you may all already know, apcera/termtables has come to a end. This commit refactor to use the fork from scylladb. ScyllaDB is an organization, so there's less chance that their own fork goes offline too.
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 899 899
=========================================
Hits 899 899 Continue to review full report at Codecov.
|
Contributor
|
👍 |
Owner
|
awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @araddon,
While I was packaging your library for Debian,
I have noticed that one of your dependency is not anymore available.
As you may all already know, apcera/termtables has come to a end.
This commit refactor to use the fork from scylladb.
ScyllaDB is an organization, so there's less chance that their
own fork goes offline too.
This PR fix #90 and is a lighter fix than the one proposed in #89 (vendoring termtables) because there's nothing else than repairing the library in this PR.
I don't know what do you think about this. Just let me know If you have another solution.
I require your library to package another one, so this fix is really important for me, and I'm willing to take time to do it in another way if you prefer.
Cheers