Improved the diagrams #75
Conversation
sohkai
left a comment
sohkai
left a comment
There was a problem hiding this comment.
Added 449f673 to prettify and clarify the script and ids a little bit, but aside from the small comment on the image it looks good to me!
The contrast on the blue background / white text has been something we've been thinking about for a long time in terms of potentially accessibility, but it's what we have for now 🤷♂️.
|
|
||
|  | ||
| <!-- Show animated svg equivalent of assets/fwd.gif --> | ||
| <div id="fwd-call"></div> |
There was a problem hiding this comment.
Only things I'd change in this image:
- In the DAO ACL Permissions section, using a
:instead of a,to separate the entity- It seems like
exec teamis duplicated here?
- It seems like
- For the functions, it make look better to put the closing brace on a new line indented the same as the start, e.g.
canPerform(
param1,
param2
)
There was a problem hiding this comment.
Hi @sohkai can you say exactly what you want for the DAO ACL Permissions section? I'm a bit confused.
There was a problem hiding this comment.
Right now the section is:
DAO ACL Permissions
- exec team, ...
- voting (ANT), ...
- exec team, ...
But instead of the ,, it would probably look nicer as
- exec team: ... (merged with the duplicate?)
- voting (ANT): ...
There was a problem hiding this comment.
The Aragon DAC team is out of funds and can't pay for this final revision. Perhaps the A1 team has funds for this. If so, you can reach out to @alanborger on keybase. Here are the source files:
https://docs.google.com/drawings/d/14mGaTC503hjMJNNi60w4KBv91V8huCIB7YseHpjLIy0/edit
https://docs.google.com/drawings/d/1pUg43SrocxqqsaSMwBBe6nVbhBwZcrDiQ9QXrgkgfeI/edit
https://docs.google.com/drawings/d/1PbjL-oK12Lls77SFyjtwbuf9gad8waDQbq8ff8R0IZY/edit
https://docs.google.com/drawings/d/1J_rhbrJksdaOdbPnfgMwWF8nRpwKKj-sfNjAR8urSvc/edit
https://docs.google.com/drawings/d/1eERE8U8XdGS0PyIlzUgamZdPJ1728ffQUOqeb8nL7HA/edit
lkngtn
left a comment
lkngtn
left a comment
There was a problem hiding this comment.
Is this PR still relevant?
|
This seems to have better visual diagrams to explain aragonPM and app lifecycle should we try to merge it. What do you think @delfipolito? |
|
Yes, it was mostly just a few things we needed to change in the diagrams (I think now we have access to their sources). |
|
Superseded by #215 |
Closes #57
The source files for these diagrams are actually Google Drawings, so they're easy to update. These diagrams are svg so can be zoomed in on without losing definition. When we move hack.aragon to the new design we'd like to have the ability to click on the diagrams to see them in full-screen. Also note that Adri has taken a look at these and given feedback.
Thanks to @alanborger and his team for the new diagrams.