add playlist support #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added option `repeat_playlist` to `post_action`: repeat whole playlist. `repeat_message` will repeat only the last item in case of a playlist. - Added option `repeat_wait` for an extra delay between repeated messages (in seconds).
arnonym
requested changes
Apr 3, 2023
Owner
arnonym
left a comment
arnonym
left a comment
There was a problem hiding this comment.
I did a first round of review, and you've done a good job! Looking forward to your update!
ha-sip/src/call.py
Outdated
| pl = self.menu['playlist'] | ||
| if pl: | ||
| item_type, content = pl[-1].split(':', 1) | ||
| self.menu[item_type] = content.lstrip() |
Owner
There was a problem hiding this comment.
I think here you're mutating the in-memory menu and if you come back later through some return action you don't get the original playlist anymore?
Author
There was a problem hiding this comment.
That's so only the last item of the playlist will be repeated. Didn't thought about nested menus. I will see how i can handle this. (only applys to repeat_message).
Author
|
When i have the nested menu thing done, i will update the PR. |
don't alter playlist when repeat_message is given.
Make return post action more powerful. Add jump post action.
arnonym
force-pushed
the
next
branch
10 times, most recently
from
aed8c83 to
e9d69d1
Compare
arnonym
force-pushed
the
next
branch
2 times, most recently
from
d628a66 to
a86f63c
Compare
|
Is this still ongoing? |
arnonym
force-pushed
the
next
branch
2 times, most recently
from
e409580 to
6074c80
Compare
arnonym
force-pushed
the
next
branch
4 times, most recently
from
819873b to
b87ef63
Compare
arnonym
force-pushed
the
next
branch
15 times, most recently
from
3e837e5 to
d3f0c2f
Compare
arnonym
force-pushed
the
next
branch
14 times, most recently
from
01d4ce2 to
cf2a672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repeat_playlisttopost_action: repeat whole playlist.repeat_messagewill repeat only the last item in case of a playlist.repeat_waitfor an extra delay between repeated messages (in seconds).closes #37