Catch errors for protected pages #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like new empty tabs or the Chrome extension page. Didn't do no harm, but this might make you worry the extension isn't working, so we silently log a debug message
Owner
|
Awesome, thank you! It did indeed give me a sense of slight anxiety that there was always an “error” reported on the Chrome Extensions page, for the extension. At least in my initial testing, and based on my reading of your changes, this does seem to solve the issue! Amazing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like new empty tabs or the Chrome extension page. Didn't do no harm, but this might make you worry the extension isn't working, so we silently log a debug message
@arrowtype Scratching an itch here!