Skip to content

Fixing typos #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeaOtocinclus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing typos #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cpp-subprocess/subprocess.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,9 @@ namespace util
* Parameters:
* [in] str : Input string which needs to be split based upon the
* delimiters provided.
* [in] deleims : Delimiter characters based upon which the string needs
* [in] delims : Delimiter characters based upon which the string needs
* to be split. Default constructed to ' '(space) and '\t'(tab)
* [out] vector<string> : Vector of strings split at deleimiter.
* [out] vector<string> : Vector of strings split at delimiter.
*/
static inline std::vector<std::string>
split(const std::string& str, const std::string& delims=" \t")
Expand Down Expand Up @@ -648,7 +648,7 @@ namespace util
* Writes `length` bytes to the file descriptor `fd`
* from the buffer `buf`.
* Parameters:
* [in] fd : The file descriptotr to write to.
* [in] fd : The file descriptor to write to.
* [in] buf: Buffer from which data needs to be written to fd.
* [in] length: The number of bytes that needs to be written from
* `buf` to `fd`.
Expand Down Expand Up @@ -689,14 +689,14 @@ namespace util
#else
int fd = subprocess_fileno(fp);
int rbytes = 0;
int eintr_cnter = 0;
int eintr_counter = 0;

while (1) {
int read_bytes = read(fd, buf + rbytes, read_upto - rbytes);
if (read_bytes == -1) {
if (errno == EINTR) {
if (eintr_cnter >= 50) return -1;
eintr_cnter++;
if (eintr_counter >= 50) return -1;
eintr_counter++;
continue;
}
return -1;
Expand Down Expand Up @@ -1021,7 +1021,7 @@ struct error
// needed to provide the functionality of preexec_func
// ATTN: Can be used only to execute functions with no
// arguments and returning void.
// Could have used more efficient methods, ofcourse, but
// Could have used more efficient methods, of course, but
// that won't yield me the consistent syntax which I am
// aiming for. If you know, then please do let me know.

Expand Down