Stop data.decode() from crashing with UnicodeDecodeError #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential solution to the issues popping up when drf-tracking (running in Python 3) gets binary data which is encoded in something other than UTF-8. See #125.
The idea is just to ignore errors in the decoding process... Personally, I don't think drf-tracking should crash the stack just because it can't log the request. Luckily, in this case, just a keyword argument to the bytes.decode() function works... Instead of
errors='replace', it could also beerrors='ignore'.For issue #129 which is a Python 2 problem (since UTF-8 is the default in Python 3), we can combine this commit with PR #130.