Skip to content

use Composer package information for Bundle Information in "Bundles" grid #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmalyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use Composer package information for Bundle Information in "Bundles" grid #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 11 additions & 21 deletions src/Xliff2Bundle/Xliff2Bundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,20 @@
use Xliff2Bundle\DependencyInjection\Compiler\Xliff20CompilerPass;
use Pimcore\Extension\Bundle\AbstractPimcoreBundle;
use Pimcore\Extension\Bundle\PimcoreBundleInterface;
use Pimcore\Extension\Bundle\Traits\PackageVersionTrait;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
* Class AmazonMarketplaceBundle
* @package AmazonMarketplaceBundle
*/
class Xliff2Bundle extends AbstractPimcoreBundle implements PimcoreBundleInterface
{
use PackageVersionTrait;

const PACKAGE_NAME = 'asioso/pimcore-xliff2_0-module';

protected function getComposerPackageName()
{
return self::PACKAGE_NAME;
}

public function build(ContainerBuilder $container)
{
parent::build($container);
Expand All @@ -32,24 +38,8 @@ public function getNiceName()
return 'Asioso - Xliff 2.0 Bundle';
}

/**
* Bundle description as shown in extension manager
*
* @return string
*/
public function getDescription()
{
return "";
}

public function getVersion()
{
return 'v1.0';
}

public static function getSolutionVersion()
{
return "v1.0";
return $this->getVersion();
}

}