Some compilation fixes #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves one half of atomizer#8. Without this the compilation fails with: use of enum ‘MaxRectsFreeRectChoiceHeuristic’ without previous declaration It feels like these constants should've been simply imported by including rbp.h but that fails for a different reason. I wonder what the right fix is but the workaround in this commit is probably good enough.
Resolves atomizer#8. Somehow the function is called before its declaration, so the error starts with this warning: warning: implicit declaration of function ‘kickstart’ Again, this is just a workaround and I'd like to know what the right fix is, but at least the project compiles after this change.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a way this resolves #8. After the fixes both
rbp_builder.pyandbuilder.pyfinish without any errors. That said, I haven't been able to actually run the game on Linux, so I cannot really test if the changes are actually working.