Skip to content

Conversation

@erikras
Copy link
Contributor

@erikras erikras commented Sep 16, 2025

Screenshot 2025-09-16 at 09 12 22

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the company selection functionality to use a new Record Combobox component, replacing the previous decorated combobox implementation. The change simplifies the component by removing custom options provider logic in favor of built-in record type functionality.

  • Replace deprecated Combobox with Experimental_RecordCombobox
  • Remove custom companiesProvider and related search/option logic
  • Update package dependency to support new Record Combobox features

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/components/log-customer-request-dialog.tsx Adds Experimental_RecordCombobox to form components and passes it to CompaniesCombobox
src/components/comboboxes/companies-options-provider.ts Removes entire custom options provider implementation
src/components/comboboxes/companies-combobox.tsx Simplifies component to use recordTypes="company" instead of custom provider
package.json Updates attio package version to support Record Combobox functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@erikras erikras force-pushed the feature/eco-2674-record-combobox branch from 8376012 to b603d61 Compare September 16, 2025 07:13
@erikras erikras merged commit 0e7e386 into main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants