Skip to content

chore: Moved all inputs to environment variables to prevent shell command injection #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmathew92 merged 3 commits into from
Jan 6, 2026
Merged

chore: Moved all inputs to environment variables to prevent shell command injection #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2a8f3c
chore: Moved all inputs to environment variables to prevent shell com…
pmathew92 Dec 8, 2025
c3cad24
Resolved merge conflicts
pmathew92 Jan 5, 2026
2e357b0
Mminor change
pmathew92 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/actions/maven-publish/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,30 @@ runs:
curl -s "https://get.sdkman.io" | bash
source "/home/runner/.sdkman/bin/sdkman-init.sh"
sdk list java
sdk install java ${{ inputs.java-version }} && sdk default java ${{ inputs.java-version }}
sdk install java "$JAVA_VERSION" && sdk default java "$JAVA_VERSION"
env:
JAVA_VERSION: ${{ inputs.java-version }}

- uses: gradle/wrapper-validation-action@56b90f209b02bf6d1deae490e9ef18b21a389cd4 # pin@1.1.0

- name: Publish Java
shell: bash
if: inputs.is-android == 'false'
run: ./gradlew clean assemble sign publishMavenJavaPublicationToMavenRepository -PisSnapshot=false -Pversion="${{ inputs.version }}" -PossrhUsername="${{ inputs.ossr-username }}" -PossrhPassword="${{ inputs.ossr-password }}" -PsigningKey="${{ inputs.signing-key }}" -PsigningPassword="${{ inputs.signing-password }}"
run: ./gradlew clean assemble sign publishMavenJavaPublicationToMavenRepository -PisSnapshot=false -Pversion="$VERSION" -PossrhUsername="$OSSR_USERNAME" -PossrhPassword="$OSSR_PASSWORD" -PsigningKey="$SIGNING_KEY" -PsigningPassword="$SIGNING_PASSWORD"
env:
VERSION: ${{ inputs.version }}
OSSR_USERNAME: ${{ inputs.ossr-username }}
OSSR_PASSWORD: ${{ inputs.ossr-password }}
SIGNING_KEY: ${{ inputs.signing-key }}
SIGNING_PASSWORD: ${{ inputs.signing-password }}

- name: Publish Android
shell: bash
if: inputs.is-android == 'true'
run: ./gradlew clean assemble sign publishAndroidLibraryPublicationToMavenRepository -PisSnapshot=false -Pversion="${{ inputs.version }}" -PossrhUsername="${{ inputs.ossr-username }}" -PossrhPassword="${{ inputs.ossr-password }}" -PsigningKey="${{ inputs.signing-key }}" -PsigningPassword="${{ inputs.signing-password }}"
run: ./gradlew clean assemble sign publishAndroidLibraryPublicationToMavenRepository -PisSnapshot=false -Pversion="$VERSION" -PossrhUsername="$OSSR_USERNAME" -PossrhPassword="$OSSR_PASSWORD" -PsigningKey="$SIGNING_KEY" -PsigningPassword="$SIGNING_PASSWORD"
env:
VERSION: ${{ inputs.version }}
OSSR_USERNAME: ${{ inputs.ossr-username }}
OSSR_PASSWORD: ${{ inputs.ossr-password }}
SIGNING_KEY: ${{ inputs.signing-key }}
SIGNING_PASSWORD: ${{ inputs.signing-password }}
4 changes: 3 additions & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ runs:
steps:
- name: Set up JDK
uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # pin@4.8.0
env:
JAVA_VERSION : ${{ inputs.java }}
with:
java-version: ${{ inputs.java }}
java-version: ${{ env.JAVA_VERSION }}
distribution: 'temurin'

- uses: gradle/wrapper-validation-action@56b90f209b02bf6d1deae490e9ef18b21a389cd4 # pin@1.1.0
Expand Down