Skip to content

pick_random_key algorithm parameter is optional #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepture merged 1 commit into from
Dec 8, 2025
+4 −2
Merged

pick_random_key algorithm parameter is optional #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/joserfc/_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ def get_by_kid(self, kid: str | None = None, parameters: KeyParameters | None =
return keys[0]
raise InvalidKeyIdError(f"No key for kid: '{kid}'")

def pick_random_key(self, algorithm: str, parameters: KeyParameters | None = None) -> t.Optional[Key]:
key_types = self.algorithm_keys.get(algorithm)
def pick_random_key(self, algorithm: str | None = None, parameters: KeyParameters | None = None) -> t.Optional[Key]:
key_types = self.algorithm_keys.get(algorithm) if algorithm else None
if key_types:
keys = [k for k in self.keys if k.key_type in key_types]
else:
Expand Down
2 changes: 2 additions & 0 deletions tests/jwk/test_jwk_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def test_random_key(self):
self.assertIsNotNone(key1)
key2 = key_set.pick_random_key("RS256")
self.assertIsNone(key2)
key3 = key_set.pick_random_key()
self.assertIsNotNone(key3)

def test_key_set_methods(self):
key_set = KeySet.generate_key_set("oct", 8)
Expand Down
Loading