Skip to content

Conversation

@kelvin-acosta
Copy link

@kelvin-acosta kelvin-acosta commented Dec 12, 2025

Description of changes:

Currently, the generated helm charts have a crds/ directory which installs CRDs the first time the helm chart is installed. The problem with the CRDs directory is that it is not managed further in the helm lifecycle, for example with upgrade commands. This creates an alternative way to install the crds using kustomize.

I had first opened a PR in aws-controllers-k8s/eks-controller#191 but was redirected to open a PR in this repo instead.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change adds automatic generation of helm/crds/kustomization.yaml
to enable Kustomize-based CRD installation in Helm charts.

Changes:
- Add templates/helm/crds/kustomization.yaml.tpl template
- Include service-specific CRDs and common ACK CRDs
- Update releaseTemplatePaths to include the new template

The generated file lists all CRD resources for easy Kustomize usage,
including both service-specific CRDs and the common FieldExport and
IAMRoleSelector CRDs from ACK runtime.
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler December 12, 2025 16:44
@ack-prow
Copy link

ack-prow bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kelvin-acosta
Once this PR has been reviewed and has the lgtm label, please assign rushmash91 for approval by writing /assign @rushmash91 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2025
@ack-prow
Copy link

ack-prow bot commented Dec 12, 2025

Hi @kelvin-acosta. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant