Generate PutBucketTagging #4210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #4210, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/7
peterrsongg
force-pushed
the
peterrsongg/petesong/phase-3-pr5-rebased-2/7
branch
from
1591b62 to
e3669ed
Compare
peterrsongg
force-pushed
the
peterrsongg/petesong/phase-3-pr5-rebased-2/6
branch
from
8302e87 to
749a49d
Compare
peterrsongg
added a commit
that referenced
this pull request
Dec 9, 2025
stack-info: PR: #4210, branch: peterrsongg/petesong/phase-3-pr5-rebased-2/7
peterrsongg
commented
Dec 9, 2025
| xmlWriter.WriteStartElement("TagSet"); | ||
| foreach (var publicRequestTaggingTagSetValue in publicRequestTaggingTagSet) | ||
| { | ||
| if (publicRequestTaggingTagSetValue != null) |
Contributor
Author
There was a problem hiding this comment.
this change is intentional. I tested that the behavior is the same service side if a null value is set for TagSet but the original custom code uses this custom method
which eventually also does this same thing. Behavior wise, nothing changed but since PutBucketTagging also needs to do the same thing and it shares this shape. Adding the customization skipXmlIsSet affects other operations too.
peterrsongg
commented
Dec 9, 2025
| xmlWriter.WriteStartElement("TagSet"); | ||
| foreach (var publicRequestOutputLocationS3TaggingTagSetValue in publicRequestOutputLocationS3TaggingTagSet) | ||
| { | ||
| if (publicRequestOutputLocationS3TaggingTagSetValue != null) |
Contributor
Author
There was a problem hiding this comment.
same comment as above. behavior is the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates
PutBucketTaggingAssembly Comparison Output (MpuObject size changed to a nulalble int) will call this out in changelog
Motivation and Context
Testing
DRY RUN: DRY_RUN-e581806f-264b-46d0-a331-1318e27c2273
Screenshots (if appropriate)
Types of changes
Checklist
License