Skip to content

fix: dead loop inside SocaCliContext.aws() in case of SSO credentials #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staskh wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

fix: dead loop inside SocaCliContext.aws() in case of SSO credentials #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/idea/idea-sdk/src/ideasdk/aws/aws_client_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from typing import List, Dict, Any, Optional, Set
import botocore.exceptions
from botocore.client import Config
from botocore.credentials import DeferredRefreshableCredentials

AWS_CLIENT_S3 = 's3'
AWS_CLIENT_EC2 = 'ec2'
Expand Down Expand Up @@ -245,6 +246,9 @@ def are_credentials_expired(self) -> bool:
else:
raise e
else:
# To prevent a dead loop for SSO credentials
if isinstance(credentials, DeferredRefreshableCredentials):
credentials.get_frozen_credentials()
return credentials.refresh_needed(refresh_in=30)

def supported_clients(self) -> Set[str]:
Expand Down