fix: Update telemetry constants to track v2 feature seperately #5437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
reviewed
Dec 23, 2025
Collaborator
There was a problem hiding this comment.
Would entries be inconsistent for V2 with this setup? For new users this makes sense, but for users that are already using V2 and don't pip install again, they will emit telemetry for these features at their original codes (1-9) and only new users will emit telemetry in the range 11-17. Should we consider setting the V3 telemetry codes to be 11-17 and keeping V2 in the range of 1-9? I don't feel strongly either way since there are trade-offs with either approach
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.