Detect { and [ for german keyboards on Windows

[BornToBeRoot]

Issue #13

Description of changes:

The keys

• { (Alt Gr + 7)
• [ (Alt Gr + 8)

are not detected on German keyboards...

Maybe the change has side effects. But it worked for me!

If you remove the 50 from this line, it might also fix the @ key for spain keyboards:

session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go

Line 186 in c523002

case 192, 50:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[BornToBeRoot]

@yuting-fan @Yangtao-Hua can you review and fix this?

It's hard to work with the Session Manager when { and [ is not working...

[YujiaozhAws]

Thanks for reaching out. We have received this request and will update here after the internal review.

[hot22shot]

This also breaks french keyboard shortcuts for [ | {
Quite an issue for me.

[BornToBeRoot]

This should be the keys for french keyboards:

session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go

Line 192 in c523002

case 52:

        case 52:
            e.key = KeyCtrl4
        case 53:
            e.key = KeyCtrl5

@YujiaozhAws Maybe the whole functions (r.virtual_key_code) doesn't make any sense or you could remove they key codes 50-56 from it:

session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go

Line 185 in c523002

switch r.virtual_key_code {

[clienart-bmx]

I can confirm that on a french keyboard, AltGr doesn't work with the number keys from 2 to 8 (which corresponds to ASCII codes 50 to 56), but works fine with 9 (^), 0 (@) and other keys which have a third grapheme such as €]}¤.
Not being able to type ~#{[|`\ is of course very frustrating !

[clienart-bmx]

Why is this still not patched ? Every time I have to type any command which contains ~#{[|`\ I have to switch to Qwerty and use the on-screen keyboard, it's a real pain !

The issue is known, and so is the fix, so what is Amazon waiting for ?

Please fix this !!!

[johnlundberg]

How can this still be an issue two years after the merge request was opened? I have the same problem with a Swedish keyboard