connfig in json, getopt, sqlite driver, elasticsearch driver and much ♥ #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
allow to pass users from file or from command line
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
remove dead code from db_mysql Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
add signal handler to properly write files on ^C
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Owner
|
Hey @xaiki, I am so sorry for leaving this PR open for this long without getting in touch. Your work looks awesome 🎉 It's been a while since I used this project and am a little wary of the sheer volume of changes you are proposing. Thank you for your help |
Author
|
Hey Basile !
Don't worry we all have the time we have :)
I have a few more patches in my fork, I've used this a lot a few months ago on a daily basis.
Let me refresh my patches by next week so you don't review code twice.
Cheers
…On 26 April 2019 10:22:16 AM GMT-03:00, Basile Simon ***@***.***> wrote:
Hey @xaiki, I am _so_ sorry for leaving this PR open for this long
without getting in touch.>
>
Your work looks awesome 🎉 >
>
It's been a while since I used this project and am a little wary of the
sheer volume of changes you are proposing.>
Have you used the code in this PR for your personal use? I could give
it a run, see how I get on.>
>
Thank you for your help>
>
-- >
You are receiving this because you were mentioned.>
Reply to this email directly or view it on GitHub:>
#1 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Owner
|
Super, looking forward to seeing more of your work :) |
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
if that happens, don't send in a multi Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
…hor operations Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
so we can store non-existing users Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
…ass queries Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
we introduce tests, and change database format to acomodate it this is a huge update but it breaks down somehow like this: - introduce tests for db utils and drivers, use pytest, iterate automatically - pynx: properly set node attributes and introduce tweets graph (still empty) - sqlite: rewrite, more columns, more data, migrations - tsv: reorganize - DBs: introduce open, close, and _WIPE methods to all (minus mysql) Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey ! THANK YOU, i've been looking for what you built for a long time as everybody seems to have this kind of code and nobody shares.
this patch series tries to standardize the use of getopt for the command line (i think i missed a few still) and puts the configuration in json files (so you don't have to hand edit the .py), it also splits out the db logic so we can have a mysql, sqlite and elasticsearch (incomplete) driver that we specify on the commandline.
(maybe all should go to the config ?)