Skip to content

Conversation

@arlowatts
Copy link
Contributor

@arlowatts arlowatts commented Dec 19, 2023

This pull request removes unused files, such as editor configuration files. These files can easily clutter the workspace and are often unnecessarily included in built images.

@bradhead
Copy link
Contributor

I am unclear why you would remove guards from the GitIgnore. If any developer contributes from a Mac, for example, they will inadvertently commit .DS_Store files, etc... that are not relevant to the build. This creates more effort on behalf o the developer to then update the ignore in their own branch perhaps, and to what end? git ignore is for exactly that purpose -- to prevent things from going into the lineup that are not useful.
Leaving them in there is benign. There is no downside to having appropriate and exhaustive entries in the .gitignore to keep the repo as clean as possible from things that operating systems generate. I do not agree with you pulling out Mac-specific gitignore entries, or other entries based on specific IDEs like VS Code.

@arlowatts
Copy link
Contributor Author

Good catch on the mac-specific entries - I hadn't considered that different operating systems might include some files by default. I'll revert some of the changes to the gitignore.

@arlowatts arlowatts requested a review from daveb-hni December 19, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants