Skip to content

Update cpal requirement from 0.15 to 0.16 #19672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dependabot wants to merge 1 commit into from
Closed

Update cpal requirement from 0.15 to 0.16 #19672

dependabot wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2025 •
edited
Loading

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Jun 16, 2025
@dependabot dependabot bot force-pushed the dependabot/cargo/cpal-0.16 branch from 5fbb625 to 4abf39f Compare June 22, 2025 23:27
@mnmaita mnmaita added S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple bug fixes and API improvements, docs, test and examples X-Contentious There are nontrivial implications that should be thought through labels Jun 24, 2025
@mnmaita
Copy link
Member

mnmaita commented Jun 24, 2025

Migrate from oboe to ndk::audio. NOTE: This raises the minimum Android API version to 26 (Android 8/Oreo).

This seems to be the breaking change in this version.

@dependabot
Update cpal requirement from 0.15 to 0.16
173b186 
---
updated-dependencies:
- dependency-name: cpal
  dependency-version: 0.16.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/cpal-0.16 branch from 4abf39f to 173b186 Compare July 7, 2025 20:48
@mnmaita
Copy link
Member

mnmaita commented Jul 24, 2025

@mockersf @alice-i-cecile do we need to add some notes somewhere regarding the minimum Android API required due to this update? I'm leaving an approval since it seems straightforward to update besides this detail.

@alice-i-cecile alice-i-cecile added M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jul 27, 2025 •
edited
Loading

We should add a migration guide, and try to update the Android docs to match.

We also need to ensure that this matches the rodio version we're using.

@mnmaita mnmaita self-assigned this Jul 28, 2025
@mnmaita
Copy link
Member

mnmaita commented Jul 28, 2025

@alice-i-cecile latest rodio uses cpal 0.16 so I'm looking into upgrading both. It's quite involved though so I'll push a draft PR once I have something semi-reviewable.

@mnmaita mnmaita mentioned this pull request Jul 29, 2025
Open
@mnmaita
Copy link
Member

mnmaita commented Dec 18, 2025

Will be resolved by #20323

@mnmaita mnmaita closed this Dec 18, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/cpal-0.16 branch December 18, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mnmaita mnmaita mnmaita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnmaita mnmaita

Labels

C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnmaita @alice-i-cecile