zCamera, xCamera, and various related files + some cleanup #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.bss |
15.38% | 14.81% | --262 |
| 📈 | .rodata |
0.11% | 0.17% | +12 |
| 📈 | .sbss |
45.23% | 46.21% | +4 |
| 📈 | .sdata2 |
6.11% | 24.41% | +93 |
| 📈 | .text |
3.40% | 7.33% | +4322 |
| ️ |
.text |
100.00% | 7.33% | --101924 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | zCameraFly_Load(zCameraFly*, xSerial*) |
0.00% | 100.00% | +32 |
| ✅ | zCameraFly_Save(zCameraFly*, xSerial*) |
0.00% | 100.00% | +32 |
| ✅ | zCameraFly_Update(xBase*, xScene*, float) |
0.00% | 100.00% | +4 |
| ✅ | zCameraFly_Setup(zCameraFly*) |
0.00% | 100.00% | +16 |
| 📈 | zCameraFly_Init(xBase&, xDynAsset&, unsigned long) |
0.00% | 95.96% | +99 |
| ✅ | zCameraMinTargetHeightClear() |
0.00% | 100.00% | +12 |
| ✅ | zCameraMinTargetHeightSet(float) |
0.00% | 100.00% | +8 |
| ✅ | zCameraSetReward(int) |
0.00% | 100.00% | +32 |
| ✅ | zCameraDisableWallJump(xCamera*) |
0.00% | 100.00% | +24 |
| 📈 | zCameraEnableWallJump(xCamera*, const xVec3&) |
0.00% | 57.95% | +153 |
| ✅ | zCameraTranslate(xCamera*, float, float, float) |
0.00% | 100.00% | +76 |
| ✅ | xCamera::operator=(const xCamera&) |
0.00% | 100.00% | +1116 |
| ✅ | zCameraGetConvers() |
0.00% | 100.00% | +8 |
| ✅ | zCameraGetLassoCamFactor() |
0.00% | 100.00% | +8 |
| ✅ | zCameraSetLassoCamFactor(float) |
0.00% | 100.00% | +8 |
| ✅ | zCameraEnableLassoCam() |
0.00% | 100.00% | +12 |
| ✅ | zCameraDisableLassoCam() |
0.00% | 100.00% | +12 |
| ✅ | zCameraEnableInput() |
0.00% | 100.00% | +12 |
| ✅ | zCameraDisableInput() |
0.00% | 100.00% | +12 |
| ✅ | zCameraIsTrackingDisabled() |
0.00% | 100.00% | +8 |
| ✅ | zCameraEnableTracking(camera_owner_enum) |
0.00% | 100.00% | +16 |
| ✅ | zCameraDisableTracking(camera_owner_enum) |
0.00% | 100.00% | +16 |
| ✅ | zCameraSetPlayerVel(xVec3*) |
0.00% | 100.00% | +8 |
| ✅ | zCameraSetHighbounce(int) |
0.00% | 100.00% | +48 |
| ✅ | zCameraSetLongbounce(int) |
0.00% | 100.00% | +48 |
| ✅ | zCameraSetBbounce(int) |
0.00% | 100.00% | +8 |
| 📈 | zCameraUpdate(xCamera*, float) |
0.00% | 0.68% | +40 |
| ✅ | zCameraIsFlyCamRunning() |
0.00% | 100.00% | +8 |
| 📈 | zCameraFreeLookSetGoals(xCamera*, float, float&, float&, float&, float&, float) |
0.00% | 16.21% | +182 |
| ✅ | zCameraFlyRestoreBackup(xCamera*) |
0.00% | 100.00% | +1176 |
| ✅ | zCameraFlyStart(unsigned int) |
0.00% | 100.00% | +156 |
| 📈 | zCameraFlyUpdate(xCamera*, float) |
0.00% | 34.04% | +931 |
| ✅ | zCameraReset(xCamera*) |
99.99% | 100.00% | +/-0 |
main/SB/Game/zWad2
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata |
2.11% | 8.42% | +12 |
| 📈 | .text |
2.20% | 2.21% | +20 |
| ️ |
.text |
100.00% | 2.21% | --128484 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | zMenuPause(bool) |
69.71% | 100.00% | +20 |
main/SB/Game/zWad3
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
6.99% | 7.07% | +157 |
| ️ |
.text |
100.00% | 7.07% | --183402 |
| 📈 | .text |
0.00% | 7.07% | +13953 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | zVolume_OccludePrecalc(xVec3*) |
39.98% | 56.17% | +157 |
main/SB/Core/x/xWad4
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.sdata2 |
39.00% | 37.90% | --1 |
| 📈 | .text |
16.11% | 16.39% | +344 |
| 📈 | .text |
0.00% | 16.39% | +20360 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xParCmdRotateAround_Update(xParCmd*, xParGroup*, float) |
68.53% | 85.38% | +60 |
| 📈 | xParCmdVelocityApply_Update(xParCmd*, xParGroup*, float) |
18.18% | 36.66% | +32 |
| 📈 | xParCmdMoveRandom_Update(xParCmd*, xParGroup*, float) |
7.59% | 12.43% | +60 |
| ✅ | xParCmdMove_Update(xParCmd*, xParGroup*, float) |
0.00% | 100.00% | +136 |
| ✅ | xParCmdAccelerate_Update(xParCmd*, xParGroup*, float) |
18.21% | 100.00% | +111 |
| 📈 | xParCmdOrbitLine_Update(xParCmd*, xParGroup*, float) |
0.00% | 16.13% | +43 |
| ️ |
xParCmdOrbitPoint_Update(xParCmd*, xParGroup*, float) |
5.84% | 0.16% | --9 |
| ️ |
xPadNormalizeAnalog(_tagxPad&, int, int) |
80.41% | 70.51% | --89 |
main/SB/Core/x/xWad2
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
28.10% | 29.05% | +4 |
| 📈 | .text |
13.30% | 13.85% | +1221 |
| 📈 | .text |
0.00% | 13.85% | +30544 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xFXRingCreate(const xVec3*, const xFXRing*) |
71.29% | 78.86% | +21 |
| 📈 | xtextbox::layout::calc(const xtextbox&, unsigned long) |
46.71% | 50.90% | +101 |
| 📈 | xEntMotionInit(xEntMotion*, xEnt*, xEntMotionAsset*) |
72.58% | 79.72% | +44 |
| 📈 | xEntDriveUpdate(xEntDrive*, xScene*, float, const xCollis*) |
34.80% | 50.53% | +548 |
| 📈 | xEntDriveMount(xEntDrive*, xEnt*, float, const xCollis*) |
49.93% | 51.88% | +35 |
| 📈 | xEntCollideFloor(xEnt*, xScene*, float) |
70.90% | 82.79% | +134 |
| 📈 | xEntCollCheckOneEntNoDepen(xEnt*, xScene*, void*) |
68.93% | 70.67% | +23 |
| 📈 | xEntCollide(xEnt*, xScene*, float) |
55.19% | 57.33% | +33 |
| ️ |
xEntApplyPhysics(xEnt*, xScene*, float) |
49.82% | 49.55% | --1 |
| 📈 | xEntMove(xEnt*, xScene*, float) |
22.44% | 30.10% | +66 |
| 📈 | xEntBeginUpdate(xEnt*, xScene*, float) |
37.15% | 64.31% | +108 |
| 📈 | @unnamed@xWad2_cpp@::update_stacked_entity(xScene&, xEnt&, float) |
0.00% | 14.85% | +104 |
main/SB/Core/x/xWad3
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
37.50% | 44.94% | +15 |
| 📈 | .text |
15.97% | 16.31% | +205 |
| 📈 | .text |
0.00% | 16.31% | +9778 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xMovePointSplineSetup(xMovePoint*) |
64.20% | 100.00% | +147 |
| 📈 | xQuatFromAxisAngle(xQuat*, const xVec3*, float) |
53.81% | 81.73% | +58 |
main/SB/Core/x/xWad1
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
21.15% | 30.00% | +27 |
| 📈 | .text |
14.17% | 14.38% | +371 |
| 📈 | .text |
0.00% | 14.38% | +25827 |
| 📈 | .text |
0.00% | 14.38% | +25827 |
| 📈 | .text |
0.00% | 14.38% | +25827 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xRayHitsSphereFast(const xRay3*, const xSphere*) |
77.88% | 100.00% | +58 |
| 📈 | xBoundOBBIsectRay(const xBox*, const xMat4x3*, const xRay3*, xIsect*) |
80.77% | 89.37% | +117 |
| 📈 | xBoundGetSphere(xSphere&, const xBound&) |
16.71% | 17.69% | +9 |
| 📈 | xBoundGetBox(xBox&, const xBound&) |
19.13% | 42.61% | +64 |
| 📈 | xBoundUpdate(xBound*) |
22.23% | 51.88% | +122 |
main/SB/Core/x/xWad5
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
6.67% | 13.67% | +32 |
| 📈 | .text |
5.80% | 5.82% | +30 |
| 📈 | .text |
0.00% | 5.82% | +7702 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xCameraFXShakeUpdate(cameraFX*, float, const xMat4x3*, xMat4x3*) |
51.22% | 54.59% | +30 |
main/SB/Core/gc/iWad
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
40.36% | 54.17% | +32 |
| 📈 | .text |
18.22% | 18.57% | +352 |
| 📈 | .text |
0.00% | 18.57% | +19073 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | iBoxVecDist(const xBox*, const xVec3*, xIsect*) |
86.27% | 91.69% | +111 |
| 📈 | iSphereBoundVec(xSphere*, const xSphere*, const xVec3*) |
38.09% | 52.34% | +82 |
| ✅ | iLightModify(iLight*, unsigned int) |
37.00% | 100.00% | +158 |
main/SB/Game/zFMV
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
35.19% | 36.66% | +5 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | zFMVPlay(const char*, unsigned int, float, unsigned int, bool, bool) |
0.00% | 2.59% | +5 |
main/SB/Core/x/xCamera
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sbss |
0.00% | 29.41% | +7 |
| 📈 | .sdata |
0.00% | 30.00% | +4 |
| 📈 | .sdata2 |
0.00% | 59.46% | +90 |
| 📈 | .text |
20.93% | 55.99% | +4339 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xCameraRotate(xCamera*, const xVec3&, float, float, float, float) |
66.34% | 100.00% | +152 |
| ✅ | xCameraRotate(xCamera*, const xMat3x3&, float, float, float) |
50.30% | 100.00% | +208 |
| ✅ | xCameraLookYPR(xCamera*, unsigned int, float, float, float, float, float, float) |
52.81% | 100.00% | +179 |
| 📈 | xCameraFOV(xCamera*, float, float, float) |
0.00% | 99.05% | +83 |
| 📈 | xCameraMove(xCamera*, const xVec3&, float) |
18.85% | 49.68% | +115 |
| ✅ | xCameraMove(xCamera*, const xVec3&) |
0.00% | 100.00% | +80 |
| ✅ | xCameraMove(xCamera*, unsigned int, float, float, float, float, float, float) |
74.96% | 100.00% | +126 |
| ✅ | xCameraDoCollisions(int, int) |
38.93% | 100.00% | +34 |
| ✅ | xCameraUpdate(xCamera*, float) |
29.20% | 100.00% | +138 |
| 📈 | _xCameraUpdate(xCamera*, float) |
0.07% | 43.98% | +2620 |
| 📈 | SweptSphereHitsCameraEnt(xScene*, xRay3*, xQCData*, xEnt*, void*) |
68.33% | 73.99% | +49 |
| 📈 | xCam_buildbasis(xCamera*) |
41.46% | 64.31% | +164 |
| 📈 | xCameraReset(xCamera*, float, float, float) |
31.52% | 60.98% | +298 |
| ✅ | xCameraInit(xCamera*, unsigned int, unsigned int) |
0.00% | 100.00% | +88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of an unfocused PR due to how much cleanup I needed to do, sorry
TODO: Explain all the regressions