Fix players getting stuck in rock in map corners when entering a level #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in level flipping where stairs and ladders in their sentinel positions (i.e. x = 0) were being flipped out of them when SporkHack generated random vaults that allowed the level to be flipped (yes, the placement of a single vault can flip THE ENTIRE LEVEL). This bug could be seen most often when starting a new game, where the upstair is `sstairs` (special/branch stairs; a comment in `use_defensive()` claims otherwise, but gdb proves it wrong). The start-of-game code calls `u_on_upstairs()`, which is supposed to put the player on these stairs but instead prioritizes the regular upstairs that have been flipped from x = 0 to x = 79, thus starting the player in the corner of the level surrounded by rock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in level flipping where stairs and ladders in their sentinel positions (i.e. x = 0) were being flipped out of them when SporkHack generated random vaults that allowed the level to be flipped (yes, the placement of a single vault can flip THE ENTIRE LEVEL).
This bug could be seen most often when starting a new game, where the upstair is
sstairs(special/branch stairs; a comment inuse_defensive()claims otherwise, but gdb proves it wrong). The start-of-game code callsu_on_upstairs(), which is supposed to put the player on these stairs but instead prioritizes the regular upstairs that have been flipped from x = 0 to x = 79, thus starting the player in the corner of the level surrounded by rock.