fix: Prevent name conflict in config method #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config module imports `password`. Previously, the `setPassword` method used the conflicting argument name `password`, which shadowed the name of the imported module. It also attemptd to _use_ the shadowed module name if `self.pw` was None, which means that sometimes the method would work, and sometimes it wouldn't. I've resolved this by renaming the argument name to `password_value`.
buhtz
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config module imports
password. Previously, thesetPasswordmethod used the conflicting argument namepassword, which shadowed the name of the imported module. It also attemptd to use the shadowed module name ifself.pwwas None, which means that sometimes the method would work, and sometimes it wouldn't.I've resolved this by renaming the argument name to
password_value.(Needed by #2039)