support matching on other state during state change #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
approved these changes
Dec 9, 2025
Comment on lines
+165
to
+167
| // Additional properties that must be true at the time of the state change for the rule to match. | ||
| // Since state changes do not match against a particular log, tags and messages will not be visibile to this matcher. | ||
| matcher.v1.LogMatcher log_matcher = 5; |
Contributor
There was a problem hiding this comment.
Agree this makes sense. It's kind of odd that we use the LogMatcher when we can only match on a part of it. Not sure if it's worth somehow factoring this out while it's still possible? If it's hard not a big deal.
Contributor
Author
There was a problem hiding this comment.
I could do another tree structure with new matcher lists etc but not sure if it's worth the complexity just for stronger typing, figured we could validate this during conversion and call it a day?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.