-
Notifications
You must be signed in to change notification settings - Fork 922
[PM-29947] Remove ResetMasterPassword property from token response model #6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-29947] Remove ResetMasterPassword property from token response model #6285
Conversation
Remove the `shouldResetMasterPassword` field (mapped to "ResetMasterPassword") from the `GetTokenResponseJson` network model. This property is no longer processed or required in the identity service response handling. - Delete the `shouldResetMasterPassword` property and its serialization annotation from the `GetTokenResponseJson` data class. - Update unit tests in `AuthRepositoryTest`, `GetTokenResponseExtensionsTest`, and `IdentityServiceTest` to remove the `shouldResetMasterPassword` argument from the `GetTokenResponseJson` constructor calls.
|
Claude finished @SaintPatrck's task in 2m 16s —— View job Code Review Complete ✓
Overall Assessment: APPROVE This PR correctly removes the unused |
|
Great job! No new security vulnerabilities introduced in this pull request |
Remove the outdated documentation for the `shouldResetMasterPassword` property in `GetTokenResponseJson`. The `shouldResetMasterPassword` property is no longer present in the `GetTokenResponseJson` data class, but its KDoc documentation remained. This change cleans up the KDoc to accurately reflect the available properties.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6285 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 762 762
Lines 54530 54530
Branches 7833 7833
=======================================
Hits 46630 46630
Misses 5183 5183
Partials 2717 2717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

🎟️ Tracking
PM-29947
📔 Objective
Remove the
shouldResetMasterPasswordfield (mapped to "ResetMasterPassword") from theGetTokenResponseJsonnetwork model. This property is no longer processed or required in the identity service response handling.shouldResetMasterPasswordproperty and its serialization annotation from theGetTokenResponseJsondata class.AuthRepositoryTest,GetTokenResponseExtensionsTest, andIdentityServiceTestto remove theshouldResetMasterPasswordargument from theGetTokenResponseJsonconstructor calls.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes