[PM-25906] Add account switcher visibility tests #2168
Conversation
LRNcardozoWDF
requested review from
a team and
matt-livefront
as code owners
|
Claude finished @LRNcardozoWDF's task in 3m 44s —— View job Review CompleteI've completed a comprehensive review of the iOS 26 account switcher visibility tests. Critical Issue FoundVaultUnlockProcessorTests.swift:887 - Contradictory iOS version guard The test
This test should use All other pre-iOS 26 tests in this file correctly use Suggested ImprovementVaultAutofillListProcessorTests.swift:115 - Unrelated whitespace change A blank line was removed from a multi-line string assertion. Consider documenting this change or reverting if unintentional to keep the PR focused on iOS 26 test additions. Positive Observations
|
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2168 +/- ##
==========================================
+ Coverage 85.47% 85.65% +0.18%
==========================================
Files 1746 1746
Lines 147479 148552 +1073
==========================================
+ Hits 126059 127248 +1189
+ Misses 21420 21304 -116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| } | ||
|
|
||
| subject.state.profileSwitcherState.isVisible = true | ||
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) |
There was a problem hiding this comment.
❌ Test setup ordering issue: Mock data is configured AFTER the action is performed (line 173), but these values should be set up BEFORE calling perform() on line 173.
The lines 174-181 should be moved above line 172. The test setup should follow this order:
- Configure all mock dependencies and initial state
- Perform the action being tested
- Assert the results
This same issue appears in VaultAutofillListProcessorTests.swift:test_perform_profileSwitcher_accountPressed_iOS26() at line 201.
| } | ||
|
|
||
| subject.state.profileSwitcherState.isVisible = true | ||
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) |
There was a problem hiding this comment.
❌ Test setup ordering issue: Same problem as in VaultItemSelectionProcessorTests.swift - mock data (lines 202-209) is configured AFTER the action is performed (line 201).
Move lines 202-209 above line 200 to ensure proper test setup order.
| } | ||
|
|
||
| subject.state.profileSwitcherState.isVisible = true | ||
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) |
There was a problem hiding this comment.
❌ Critical: Test setup ordering violation
Mock data is configured AFTER the action is performed. Lines 173-180 must be moved above line 172.
Current (incorrect) order:
- Set state (line 171) ✅
- Perform action (line 172) ❌ Too early!
- Configure mocks (lines 173-180) ❌ Too late!
Correct order should be:
- Set state
- Configure all mocks (activeAccount, altAccounts, vaultTimeout)
- Then perform action
- Assert results
This follows the standard Arrange-Act-Assert pattern (Testing.md:1033-1037). Currently the test runs with uninitialized mock values, producing incorrect results.
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) | |
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) | |
| authRepository.activeAccount = .fixture(profile: .fixture(userId: "42")) | |
| authRepository.altAccounts = [ | |
| .fixture(), | |
| ] | |
| authRepository.vaultTimeout = [ | |
| "1": .fiveMinutes, | |
| "42": .immediately, | |
| ] | |
| } | ||
|
|
||
| subject.state.profileSwitcherState.isVisible = true | ||
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) |
There was a problem hiding this comment.
❌ Critical: Test setup ordering violation
Same issue as VaultItemSelectionProcessorTests - mock data (lines 201-208) is configured AFTER the action is performed (line 200).
Move lines 201-208 above line 200 to ensure mocks are configured before the test executes.
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) | |
| await subject.perform(.profileSwitcher(.accountPressed(ProfileSwitcherItem.fixture(userId: "1")))) | |
| authRepository.activeAccount = .fixture(profile: .fixture(userId: "42")) | |
| authRepository.altAccounts = [ | |
| .fixture(), | |
| ] | |
| authRepository.vaultTimeout = [ | |
| "1": .fiveMinutes, | |
| "42": .immediately, | |
| ] | |
KatherineInCode
left a comment
KatherineInCode
left a comment
There was a problem hiding this comment.
On the whole, it looks good, aside from a small thing I mentioned. And the comments Claude generated noting the mock/test order...while it appears to be that way in the original test, I do find it curious. It might be worth adding a comment to them to explain why the order is the way it is?
| throw XCTSkip("This test requires iOS 26 or later") | ||
| } | ||
|
|
||
| subject.state.profileSwitcherState.isVisible = true |
There was a problem hiding this comment.
⛏️ Doesn't the new profile switcher obviate the need for tracking the state visibility this way?
There was a problem hiding this comment.
Yes, thank you for calling this out.
…l-account-switcher-visibility-tests
|
Overall Assessment: APPROVE Reviewed comprehensive iOS 26 test coverage additions for account switcher visibility across 5 processor test files. Summary: Test Coverage Added:
Positive Observations:
Minor Observation (Not Blocking):
Example from VaultItemSelectionProcessorTests.swift:167-193: // Current order works but could be clearer:
subject.state.profileSwitcherState.isVisible = true // State set first
authRepository.activeAccount = ... // Then mocks
authRepository.altAccounts = ...
authRepository.vaultTimeout = ...
await subject.perform(...) // Then action
// Suggested (more explicit Arrange-Act-Assert):
authRepository.activeAccount = ... // Mocks first
authRepository.altAccounts = ...
authRepository.vaultTimeout = ...
subject.state.profileSwitcherState.isVisible = true // State second
await subject.perform(...) // Action lastThis is a stylistic preference for improved readability and doesn't affect test correctness. Recommendation: APPROVE - This PR meets quality standards and adds valuable test coverage for iOS 26 compatibility. |
|
@KatherineInCode about the comments Claude made about the order of the mock, I noticed that for the new profile switcher we could implement the tests in another way. |
🎟️ Tracking
PM-25906
📔 Objective
Add tests for account switcher for iOS 26.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes