[PM-22202] Perform sync in Fido2 findCredentials when they have counter

[fedemkr]

🎟️ Tracking

PM-22202

📔 Objective

Performance improvement to only sync credentials in Fido2 flows when there are Fido2 credentials with counter > 0 and the sync is needed (30 min have passed since last one).

Important

findCredentials now calls a private function to prevent infinite loop while using recursion in some edge cases sync may present.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – e19043b9-ebf3-4088-b388-8acf0183bbac

Great job! No new security vulnerabilities introduced in this pull request

[claude]

Claude finished @fedemkr's task in 2m 11s —— View job

---

Code Review Complete

• Analyzing PR changes
• Reviewing code quality and architecture
• Checking tests and documentation
• Posted review comments

The code review agent has analyzed this PR and posted inline comments with findings. Please review the inline comments for specific feedback.

[claude]

Code Review in Progress

• Analyzing PR changes
• Reviewing code quality and architecture
• Checking tests and documentation
• Posting review comments

View job run

[codecov]

Codecov Report

❌ Patch coverage is 97.79006% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.54%. Comparing base (fdf8495) to head (72582a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...lt/Services/Fido2CredentialStoreServiceTests.swift	97.26%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   85.52%   85.54%   +0.01%     
==========================================
  Files        1738     1738              
  Lines      147216   147383     +167     
==========================================
+ Hits       125909   126073     +164     
- Misses      21307    21310       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.