Skip to content

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Dec 23, 2025

🎟️ Tracking

PM-30147

📔 Objective

Added weak self for context perform on FetchedResultsSubscription to see if that fixes a crash happening sometimes when fetching CoreData.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr requested review from a team and matt-livefront as code owners December 23, 2025 14:13
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailscafb58cc-9ce3-4cb3-b64f-13feab23b29c

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.18%. Comparing base (33da013) to head (52f0b00).

Files with missing lines Patch % Lines
...e/Platform/Utilities/FetchedResultsPublisher.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
- Coverage   85.47%   84.18%   -1.30%     
==========================================
  Files        1746     1987     +241     
  Lines      147479   162611   +15132     
==========================================
+ Hits       126059   136886   +10827     
- Misses      21420    25725    +4305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants